This repository has been archived by the owner on Jan 14, 2022. It is now read-only.
Fontawesome Update - Closes #839 #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalTuleja
suggested changes
Dec 7, 2018
src/index.ejs
Outdated
| <% if (htmlWebpackPlugin.options.serviceName && htmlWebpackPlugin.options.clientId) { %> | ||
| <meta name="<%= htmlWebpackPlugin.options.serviceName %>" content="<%= htmlWebpackPlugin.options.clientId %>"> | ||
| <% } %> | ||
|
|
||
| <!--<link rel="stylesheet" href="/css/main.min.css">--> | ||
| <link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.5.0/css/all.css"> |
There was a problem hiding this comment.
Instead of using the <link> tag, the main CSS and the shim file can be imported directly in the src/app/app.js, in the styles section.
MichalTuleja
suggested changes
Dec 10, 2018
app.js
Outdated
| `font-src 'self' https://fonts.gstatic.com data:`, | ||
| `style-src 'self' 'unsafe-inline' https://fonts.googleapis.com https://use.fontawesome.com/;`, | ||
| `script-src 'self' 'unsafe-eval' 'unsafe-inline' https://tagmanager.google.com/ https://www.googletagmanager.com/ https://www.google-analytics.com/ https://dnn506yrbagrg.cloudfront.net/ https://*.ipify.org/ https://*.crazyegg.com/ http://trk.cetrk.com/ https://s3.amazonaws.com/trk.cetrk.com/ https://use.fontawesome.com/;`, | ||
| `font-src 'self' https://fonts.gstatic.com https://use.fontawesome.com/;`, |
There was a problem hiding this comment.
font-awesome references can be removed from the security policy
added 2 commits
December 10, 2018 14:19
MichalTuleja
approved these changes
Dec 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Fontawesome v4 didn't support some icons we wanted to display. So needed to upgrade it to v5.
How did I fix it?
How to test it?
Review checklist
commit guidelines